cloud-fan commented on a change in pull request #24832: [SPARK-27845][SQL]
DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r307165493
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -294,8 +294,8 @@ query
;
insertInto
- : INSERT OVERWRITE TABLE tableIdentifier (partitionSpec (IF NOT EXISTS)?)?
#insertOverwriteTable
- | INSERT INTO TABLE? tableIdentifier partitionSpec?
#insertIntoTable
+ : INSERT OVERWRITE TABLE? multipartIdentifier (partitionSpec (IF NOT
EXISTS)?)? #insertOverwriteTable
+ | INSERT INTO TABLE? multipartIdentifier partitionSpec? (IF NOT EXISTS)?
#insertIntoTable
Review comment:
Actually, `IF NOT EXISTS` doesn't make sense to partition either. It's
append not overwrite, and it seems weird to me if we can't append to an
existing partition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
