cloud-fan commented on issue #25243: [SPARK-28498][SQL][TEST] always create a 
fresh copy of the SparkSession before each test
URL: https://github.com/apache/spark/pull/25243#issuecomment-515028566
 
 
   > Do we need to replace existing tests?
   
   We don't have to but we'd better too. I won't encourage people to send 
test-only PRs to do the replacement, but when I need to add a new test in one 
suite, I would probably update the suite.
   
   > I'm a bit worried about additional overheads for tests though
   
   Creating a fresh copy of the session is pretty cheap. Basically it just 
creates a new object. AFAIK the `SQLQueryTestSuite` already use fresh copy for 
each test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to