rdblue commented on a change in pull request #24832: [SPARK-27845][SQL]
DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r307371980
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -296,13 +310,13 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
override def visitInsertOverwriteTable(
ctx: InsertOverwriteTableContext): InsertTableParams = withOrigin(ctx) {
assert(ctx.OVERWRITE() != null)
- val tableIdent = visitTableIdentifier(ctx.tableIdentifier)
+ val tableIdent = visitMultipartIdentifier(ctx.multipartIdentifier)
val partitionKeys =
Option(ctx.partitionSpec).map(visitPartitionSpec).getOrElse(Map.empty)
val dynamicPartitionKeys: Map[String, Option[String]] =
partitionKeys.filter(_._2.isEmpty)
if (ctx.EXISTS != null && dynamicPartitionKeys.nonEmpty) {
- throw new ParseException(s"Dynamic partitions do not support IF NOT
EXISTS. Specified " +
- "partitions with value: " + dynamicPartitionKeys.keys.mkString("[",
",", "]"), ctx)
+ operationNotAllowed("IF NOT EXISTS with dynamic partitions: " +
Review comment:
This uses `operationNotAllowed` instead of throwing a custom
`ParseException`, like other methods that do not allow specific combinations. I
think it's a good idea to standardize on the existing method. This also makes
the error message like the others, where it states clear what is not allowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
