maropu commented on issue #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test URL: https://github.com/apache/spark/pull/25243#issuecomment-515252058 > Creating a fresh copy of the session is pretty cheap. Basically it just creates a new object. AFAIK the SQLQueryTestSuite already use fresh copy for each test. Yea, the fresh-copy overhead is ok, but how about re-creating dataframes for each test? https://github.com/apache/spark/pull/25243/files#diff-b49f76fba19ee10a28e0e61c4b44e1a0R49 It seems some existing tests (e.g., [JDBCSuite](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala#L73)) already has shared datasets for tests in a single test suite.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
