srowen commented on a change in pull request #25228:
[SPARK-28472][SQL][TEST][test-hadoop3.2] Add test for thriftserver protocol
versions
URL: https://github.com/apache/spark/pull/25228#discussion_r307552165
##########
File path:
sql/hive-thriftserver/v1.2.1/src/main/scala/org/apache/spark/sql/hive/thriftserver/ThriftserverShimUtils.scala
##########
@@ -46,4 +49,13 @@ private[thriftserver] object ThriftserverShimUtils {
private[thriftserver] def toJavaSQLType(s: String): Int =
Type.getType(s).toJavaSQLType
+ private[thriftserver] val testedProtocalVersions = Seq(
Review comment:
Protocal -> Protocol
Do we really have to test against so many versions? how many are in use by
versions of Hive supported by 3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
