mgaido91 commented on a change in pull request #25253: [SPARK-28470][SQL] Cast
to decimal throws ArithemticException on overflow
URL: https://github.com/apache/spark/pull/25253#discussion_r307625834
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -498,22 +499,34 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
b => x.numeric.asInstanceOf[Numeric[Any]].toInt(b).toByte
}
+ private val nullOnOverflow = SQLConf.get.decimalOperationsNullOnOverflow
+
/**
* Change the precision / scale in a given decimal to those set in
`decimalType` (if any),
* returning null if it overflows or modifying `value` in-place and
returning it if successful.
*
* NOTE: this modifies `value` in-place, so don't call it on external data.
*/
private[this] def changePrecision(value: Decimal, decimalType: DecimalType):
Decimal = {
- if (value.changePrecision(decimalType.precision, decimalType.scale)) value
else null
+ if (value.changePrecision(decimalType.precision, decimalType.scale)) {
+ value
+ } else {
Review comment:
I agree with @gengliangwang but I am fine changing it. Please @HyukjinKwon
let me know if you think we should change it, I'll do it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
