gatorsmile commented on a change in pull request #25107: [SPARK-28344][SQL]
detect ambiguous self-join and fail the query
URL: https://github.com/apache/spark/pull/25107#discussion_r307816556
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1312,10 +1326,24 @@ class Dataset[T] private[sql](
colRegex(colName)
} else {
val expr = resolve(colName)
- Column(expr)
+ Column(addDataFrameIdToCol(expr))
Review comment:
This is the only place that requires calling `addDataFrameIdToCol`. How
about colRegex?
We might need a clear comment and explain which cases we should call it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
