gatorsmile commented on a change in pull request #25217: [SPARK-28463][SQL]
Thriftserver throws BigDecimal incompatible with HiveDecimal
URL: https://github.com/apache/spark/pull/25217#discussion_r307838014
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -654,6 +654,14 @@ class HiveThriftBinaryServerSuite extends
HiveThriftJdbcTest {
assert(resultSet.getString(1) === "4.56")
}
}
+
+ test("SPARK-28463: Thriftserver throws BigDecimal incompatible with
HiveDecimal") {
Review comment:
That also indicates our thrift server might have various issues we might not
catch.
Could you bulid a test framework that can directly re-run all the tests in
SQLQueryTestSuite via Thrift Server? We do not need to run them always, since
they could be very time consuming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
