yeshengm commented on a change in pull request #25249: [SPARK-28237][SQL] 
Enforce Idempotence for Once batches in RuleExecutor
URL: https://github.com/apache/spark/pull/25249#discussion_r307841158
 
 

 ##########
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullupCorrelatedPredicatesSuite.scala
 ##########
 @@ -27,6 +27,8 @@ import org.apache.spark.sql.catalyst.rules.RuleExecutor
 class PullupCorrelatedPredicatesSuite extends PlanTest {
 
   object Optimize extends RuleExecutor[LogicalPlan] {
+    override protected val blacklistedOnceBatches = 
Set("PullupCorrelatedPredicates")
 
 Review comment:
   I don't think so cuz currently this rule generates wrong plans if run 
multiple times. See #25164 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to