dilipbiswal commented on a change in pull request #25164: [SPARK-28375][SQL]
Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates
if run multiple times
URL: https://github.com/apache/spark/pull/25164#discussion_r307925996
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -275,13 +275,16 @@ object PullupCorrelatedPredicates extends
Rule[LogicalPlan] with PredicateHelper
plan transformExpressions {
case ScalarSubquery(sub, children, exprId) if children.nonEmpty =>
val (newPlan, newCond) = pullOutCorrelatedPredicates(sub, outerPlans)
- ScalarSubquery(newPlan, newCond, exprId)
+ val conds = newCond ++ children.filter(_.isInstanceOf[Predicate])
Review comment:
@yeshengm Thanks .. let me make a pr to get it tested to see what is broken.
I think it makes sense to keep this logic (even though its merged with
rewriteSubquery) idempotent. That is because, pullupCorrelatedPredicates works
for scalar subquery as well and that is handled by a different rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
