dongjoon-hyun commented on a change in pull request #25270: [SPARK-28535][core] 
Slow down tasks to de-flake JobCancellationSuite.
URL: https://github.com/apache/spark/pull/25270#discussion_r307944399
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala
 ##########
 @@ -365,7 +365,10 @@ class JobCancellationSuite extends SparkFunSuite with 
Matchers with BeforeAndAft
       }.foreachAsync { x =>
         // Block this code from being executed, until the job get cancelled. 
In this case, if the
         // source iterator is interruptible, the max number of increment 
should be under
-        // `numElements`.
+        // `numElements`. We sleep a little to make sure that we leave enough 
time for the
+        // "kill" message to be delivered to the executor (10000 * 10ms = 100s 
allowance for
+        // delivery, which should be more than enough).
+        Thread.sleep(10)
 
 Review comment:
   So, we need this in master/2.4/2.3.
   cc @jiangxb1987 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to