maropu commented on a change in pull request #25276: [SPARK-28545][SQL] Add the 
hash map size to the directional log of ObjectAggregationIterator
URL: https://github.com/apache/spark/pull/25276#discussion_r307980684
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala
 ##########
 @@ -161,7 +161,7 @@ class ObjectAggregationIterator(
         // The the hash map gets too large, makes a sorted spill and clear the 
map.
         if (hashMap.size >= fallbackCountThreshold) {
           logInfo(
-            s"Aggregation hash map reaches threshold " +
+            s"Aggregation hash map size ${hashMap.size} reaches threshold " +
               s"capacity ($fallbackCountThreshold entries), spilling and 
falling back to sort" +
               s" based aggregation. You may change the threshold by adjust 
option " +
 
 Review comment:
   (not related to this pr though...) we don't need the prefix `s` here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to