Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3997#discussion_r23087164
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -449,6 +461,37 @@ class SparseVector(
override def toString: String =
"(%s,%s,%s)".format(size, indices.mkString("[", ",", "]"),
values.mkString("[", ",", "]"))
+ override def equals(other: Any): Boolean = {
+ other match {
+ case v: SparseVector => {
+ if (this.size != v.size) { return false }
+ val thisValues = this.values
+ val thisIndices = this.indices
+ val thisSize = thisValues.size
+ val otherValues = v.values
+ val otherIndices = v.indices
+ val otherSize = otherValues.size
+
+ var k1 = 0
+ var k2 = 0
+ var allEqual = true
+ while (allEqual) {
+ while (k1 < thisSize && thisValues(k1) == 0) k1 += 1
+ while (k2 < otherSize && otherValues(k2) == 0) k2 += 1
+
+ if (k1 >= thisSize || k2 >= otherSize) {
+ return k1 >= thisSize && k2 >= otherSize // check end alignment
+ }
+ allEqual = thisIndices(k1) == otherIndices(k2) && thisValues(k1)
== otherValues(k2)
+ k1 += 1
+ k2 += 1
+ }
+ allEqual
+ }
+ case _ => super.equals(other)
+ }
+ }
+
--- End diff --
Yes I like this version. Still pretty clear, and I think it's fine to
optimize this a bit. There's still an opportunity to optimize sparse vs dense
comparison, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
