kiszk commented on a change in pull request #25264:
[SPARK-28213][SQL][followup] code cleanup and bug fix for columnar execution
framework
URL: https://github.com/apache/spark/pull/25264#discussion_r307993647
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -439,47 +431,46 @@ case class RowToColumnarExec(child: SparkPlan) extends
UnaryExecNode {
// Instead of creating a new config we are reusing columnBatchSize. In the
future if we do
// combine with some of the Arrow conversion tools we will need to unify
some of the configs.
val numRows = conf.columnBatchSize
- val converters = new RowToColumnConverter(schema)
- val rowBased = child.execute()
- rowBased.mapPartitions(rowIterator => {
- new Iterator[ColumnarBatch] {
- var cb: ColumnarBatch = null
-
- TaskContext.get().addTaskCompletionListener[Unit] { _ =>
- if (cb != null) {
- cb.close()
- cb = null
+ // This avoids calling `output` in the RDD closure, so that we don't need
to include the entire
Review comment:
nit: `output` -> `schema`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
