shahidki31 commented on a change in pull request #22502: [SPARK-25474][SQL]
When the "fallBackToHdfsForStats= true", Size in bytes is coming as default
size in bytes ( 8.0 EB)
URL: https://github.com/apache/spark/pull/22502#discussion_r307996117
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
##########
@@ -71,7 +73,13 @@ case class HadoopFsRelation(
override def sizeInBytes: Long = {
val compressionFactor = sqlContext.conf.fileCompressionFactor
- (location.sizeInBytes * compressionFactor).toLong
+ val defaultSize = (location.sizeInBytes * compressionFactor).toLong
+ location match {
+ case cfi: CatalogFileIndex if
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled =>
+ CommandUtils.getSizeInBytesFallBackToHdfs(sparkSession, new
Path(cfi.table.location),
Review comment:
If statistics is not empty, then the flow will not come to this code. Hence
irrespective of `fallBackToHdfsForStatsEnable=true` or false, stats will be
same. I have added a tests too, to verify the same.
https://github.com/apache/spark/blob/d943ee0a881540aa356cdce533b693baaf7c644f/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala#L42-L46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
