Deegue commented on a change in pull request #24740: [SPARK-27876][CORE] Split
large shuffle partition to multi-segments to enable transfer oversize shuffle
partition block
URL: https://github.com/apache/spark/pull/24740#discussion_r308045831
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
##########
@@ -290,19 +304,56 @@ public ShuffleMetrics() {
return mapIdAndReduceIds;
}
+ private int[] shuffleMapIdReduceIdAndSegmentIds(String[] blockIds, int
shuffleId) {
+ final int[] mapIdReduceIdAndSegmentIds = new int[3 * blockIds.length];
+ for (int i = 0; i < blockIds.length; i++) {
+ String[] blockIdParts = blockIds[i].split("_");
+ if (blockIdParts.length != 5 ||!blockIdParts[0].equals("shuffle")) {
Review comment:
Missing white space after `||`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]