cloud-fan commented on issue #25264: [SPARK-28213][SQL][followup] code cleanup and bug fix for columnar execution framework URL: https://github.com/apache/spark/pull/25264#issuecomment-515837966 After more thoughts, I think we should still insert `InputAdapter` under `ColumnarToRowExec`. But we can simplify the whole-stage-codegen planning logic a bit, because codegen stage can never overlap with a columnar stage, as whole-stage-codegen is completely row-based. When these 2 stages are adjacent, it's either a `RowToColumnarExec` above `WholeStageExec`, or a `ColumnarToRowExec` above the `InputAdapter`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
