yeshengm commented on a change in pull request #25268: [SPARK-28375][SQL] Make
pullupCorrelatedPredicate idempotent
URL: https://github.com/apache/spark/pull/25268#discussion_r308054019
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -273,16 +273,20 @@ object PullupCorrelatedPredicates extends
Rule[LogicalPlan] with PredicateHelper
}
private def rewriteSubQueries(plan: LogicalPlan, outerPlans:
Seq[LogicalPlan]): LogicalPlan = {
+ def getJoinCondition(newCond: Seq[Expression], oldCond: Seq[Expression]):
Seq[Expression] = {
Review comment:
Is it true that this function is to workaround cases where the `newCond` is
empty, while outer references is not empty? Maybe we should add some comment
here since it might be tricky to understand...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
