maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Support
LIKE ... ESCAPE syntax
URL: https://github.com/apache/spark/pull/25001#discussion_r308057910
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
##########
@@ -118,6 +118,295 @@ class RegexpExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkLiteralRow("""%SystemDrive%\Users\John""" like _,
"""\%SystemDrive\%\\Users%""", true)
}
+ test("LIKE Pattern ESCAPE '/'") {
+
Review comment:
These tests below are super duplicated between each other. IMHO we don't
need these over-killing tests and more simpler tests are ok to me here (Basic
tests already have been done in
https://github.com/apache/spark/pull/25001/files#diff-c36b16be93e0c63a4e3fad37bd904b29R25)
Can you write tests like this?
```
Seq("/", "#", "\"", ...).foreach { escapeChar =>
test(s"LIKE Pattern ESCAPE '$escapeChar'") {
// More simpler tests here...
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
