HyukjinKwon commented on a change in pull request #25289: [SPARK-27889] [Build]
[Deploy] Make development scripts under dev/ support Python 3
URL: https://github.com/apache/spark/pull/25289#discussion_r308309746
##########
File path: python/run-tests.py
##########
@@ -161,8 +161,13 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
def get_default_python_executables():
python_execs = [x for x in ["python2.7", "python3.6", "pypy"] if which(x)]
- if "python2.7" not in python_execs:
- LOGGER.warning("Not testing against `python2.7` because it could not
be found; falling"
+ if ("python3.6" not in python_execs) and which("python3"):
+ LOGGER.warning("Not testing against `python3.6` because it could not
be found; falling"
+ " back to `python3` instead")
+ python_execs.insert(0, "python3")
Review comment:
It's not neccessary. This script already provides an option to specify
python executables. `--python-executables`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
