zsxwing commented on a change in pull request #25292:
[SPARK-28556][SQL]QueryExecutionListener should also notify Error
URL: https://github.com/apache/spark/pull/25292#discussion_r308426021
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -58,12 +58,12 @@ trait QueryExecutionListener {
* @param funcName the name of the action that triggered this query.
* @param qe the QueryExecution object that carries detail information like
logical plan,
* physical plan, etc.
- * @param exception the exception that failed this query.
+ * @param error the exception that failed this query.
*
* @note This can be invoked by multiple different threads.
*/
@DeveloperApi
- def onFailure(funcName: String, qe: QueryExecution, exception: Exception):
Unit
+ def onFailure(funcName: String, qe: QueryExecution, error: Throwable): Unit
Review comment:
There is another issue in this API: It passes a private class
`QueryExecution` to the user in a public API. Didn't fix it as it will require
a re-design of this API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
