sarutak commented on a change in pull request #25265: [SPARK-28525][DEPLOY]
Allow Launcher to be applied Java options
URL: https://github.com/apache/spark/pull/25265#discussion_r308515668
##########
File path: bin/spark-class
##########
@@ -68,15 +68,26 @@ fi
# The exit code of the launcher is appended to the output, so the parent shell
removes it from the
# command array and checks the value to see if the launcher succeeded.
build_command() {
- "$RUNNER" -Xmx128m -cp "$LAUNCH_CLASSPATH" org.apache.spark.launcher.Main
"$@"
+ "$RUNNER" -Xmx128m $SPARK_LAUNCHER_OPTS -cp "$LAUNCH_CLASSPATH"
org.apache.spark.launcher.Main "$@"
printf "%d\0" $?
}
# Turn off posix mode since it does not allow process substitution
set +o posix
CMD=()
-while IFS= read -d '' -r ARG; do
- CMD+=("$ARG")
+DELIM=$'\n'
+while IFS= read -d "$DELIM" -r ARG; do
+ if [ -n "$CMD_START_FLAG" ]; then
Review comment:
Thanks. I'll initialize the flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
