dongjoon-hyun commented on a change in pull request #25303: [SPARK-23469]
HashingTF should use corrected MurmurHash3 implementation
URL: https://github.com/apache/spark/pull/25303#discussion_r308946273
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala
##########
@@ -75,19 +75,32 @@ class HashingTFSuite extends MLTest with
DefaultReadWriteTest {
Seq((idx("a"), 1.0), (idx("b"), 1.0), (idx("c"), 1.0)))
assert(features ~== expected absTol 1e-14)
}
-
+
Review comment:
Could you fix this scala style violation?
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala:78:0:
Whitespace at end of line
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
