HyukjinKwon commented on a change in pull request #25262:
[SPARK-28486][CORE][PYTHON] Map PythonBroadcast's data file to a BroadcastBlock
to avoid delete by GC
URL: https://github.com/apache/spark/pull/25262#discussion_r309007120
##########
File path:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala
##########
@@ -58,8 +59,19 @@ private[spark] class BroadcastManager(
new ReferenceMap(AbstractReferenceMap.HARD, AbstractReferenceMap.WEAK)
}
+ private def attachBroadcastIdForPython[T: ClassTag](value_ : T, bid: Long):
Unit = {
Review comment:
and can we add some comments, as a proper method doc, here about how it
works? TBH, looks kind of error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
