gengliangwang commented on a change in pull request #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#discussion_r309125136
########## File path: .github/PULL_REQUEST_TEMPLATE ########## @@ -1,10 +1,31 @@ -## What changes were proposed in this pull request? +<!-- Thanks for sending a pull request! Here are some tips for you: +1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html +2. Ensure you have added or ran the appropriate tests for your PR: https://spark.apache.org/developer-tools.html +3. If the PR is unfinished, add `[WIP]` in your PR title. +4. Update your PR description whenever it is needed. +--> -(Please fill in changes proposed in this fix) +### What changes were proposed in this pull request? -## How was this patch tested? +### Why changes are needed? Review comment: In the [Kubernates' PR template](https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md), the changes and reason descriptions are put in one section: ``` **What this PR does / why we need it**: ``` Just double-check, do you separate the two parts on purpose? I am actually OK with either way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
