attilapiros commented on a change in pull request #25299: [SPARK-27651][Core] 
Avoid the network when shuffle blocks are fetched from the same host
URL: https://github.com/apache/spark/pull/25299#discussion_r309178037
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/storage/BlockManagerMessages.scala
 ##########
 @@ -97,6 +97,15 @@ private[spark] object BlockManagerMessages {
   case class GetLocationsAndStatus(blockId: BlockId, requesterHost: String)
     extends ToBlockManagerMaster
 
+  case class GetLocalDirs(executorIds: Array[String]) extends 
ToBlockManagerMaster
+
+  /**
+   * The response message of `GetLocalDirs` request.
+   *
+   * @param localDirs follows the order of the block manager IDs used in the 
`GetLocalDirs` request.
 
 Review comment:
   I was wrong here: somehow I thought it is better to avoid maps in messages 
because of Kryo. But now I see it works perfectly (even with Kryo).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to