Ngone51 commented on a change in pull request #25262:
[SPARK-28486][CORE][PYTHON] Map PythonBroadcast's data file to a BroadcastBlock
to avoid delete by GC
URL: https://github.com/apache/spark/pull/25262#discussion_r309277831
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -211,7 +211,7 @@ private[spark] class BlockManager(
*
* @param blockSize the decrypted size of the block
*/
- private abstract class BlockStoreUpdater[T](
+ private[spark] abstract class BlockStoreUpdater[T](
Review comment:
I'm afraid not. if we revive the scope here, compiler would say:
```
[error]
/Users/wuyi/workspace/spark/core/src/main/scala/org/apache/spark/storage/BlockManager.scala:368:
private class BlockStoreUpdater escapes its defining scope as part of type
BlockManager.this.BlockStoreUpdater[T]
[error] extends BlockStoreUpdater[T](blockSize, blockId, level,
classTag, tellMaster, keepReadLock) {
[error] ^
[error]
/Users/wuyi/workspace/spark/core/src/main/scala/org/apache/spark/storage/BlockManager.scala:368:
no arguments allowed for nullary constructor Object: ()Object
[error] extends BlockStoreUpdater[T](blockSize, blockId, level,
classTag, tellMaster, keepReadLock) {
[error] ^
[error]
/Users/wuyi/workspace/spark/core/src/main/scala/org/apache/spark/storage/BlockManager.scala:383:
value save is not a member of Product with Serializable
[error] val res = super.save()
[error] ^
[error] three errors found
[error] Compile failed at 2019-7-31 23:08:25 [36.500s]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
