Ngone51 commented on a change in pull request #25047: [WIP][SPARK-27371][CORE]
Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r309291804
##########
File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
##########
@@ -110,6 +122,16 @@ private[deploy] object DeployMessages {
case class ReconnectWorker(masterUrl: String) extends DeployMessage
+ /**
+ * Ask the worker to release the indicated resources in
ALLOCATED_RESOURCES_JSON_FILE
+ * @param pid process id of the target worker
+ * @param toRelease the resources expected to release
+ */
+ case class ReleaseResources(
Review comment:
Make sense. I didn't think this part clearly before.
> Do we really want the other worker to say their free if its potentially
being used.
But this is one thing I'd like to clarify that `ReleaseResources` only
release those free resource of that lost worker and that's what the func
`releaseResourcesIfPossible()` do actually. Though, not important now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
