xianyinxin commented on a change in pull request #24983:
[SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder
URL: https://github.com/apache/spark/pull/24983#discussion_r309677876
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
##########
@@ -251,7 +257,7 @@ object JoinReorderDP extends PredicateHelper with Logging {
* @param filters Join graph info to be used as filters by the search
algorithm.
* @return Builds and returns a new JoinPlan if both conditions hold.
Otherwise, returns None.
*/
- private def buildJoin(
Review comment:
In the new codes, I moved the `buildJoin` to `JoinReorderUtil` and it then
can be used by both the `JoinReorderDP` and `JoinReorderGA`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
