maropu commented on a change in pull request #25331: [SPARK-27768][SQL]
Infinity, -Infinity, NaN should be recognized in a case insensitive manner.
URL: https://github.com/apache/spark/pull/25331#discussion_r309945900
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -563,7 +573,17 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
private[this] def castToFloat(from: DataType): Any => Any = from match {
case StringType =>
buildCast[UTF8String](_, s => try s.toString.toFloat catch {
- case _: NumberFormatException => null
+ case _: NumberFormatException =>
+ val str = s.trim.toString
+ if (str.equalsIgnoreCase("infinity")) {
Review comment:
IMO some users might think `inf` is more common, e.g., even in python, both
`inf` and `infinity` can be used;
```
Python 3.6.8 |Anaconda, Inc.| (default, Dec 29 2018, 19:04:46)
>>> float('inf')
inf
>>> float('infinity')
inf
```
Its ok to wait for other reviewer's comments. @gatorsmile @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
