cloud-fan commented on a change in pull request #25327: [SPARK-28593][CORE]
Rename ShuffleClient to BlockStoreClient which more close to its usage
URL: https://github.com/apache/spark/pull/25327#discussion_r309976975
##########
File path:
core/src/main/scala/org/apache/spark/network/BlockTransferService.scala
##########
@@ -26,24 +25,20 @@ import scala.reflect.ClassTag
import org.apache.spark.internal.Logging
import org.apache.spark.network.buffer.{FileSegmentManagedBuffer,
ManagedBuffer, NioManagedBuffer}
-import org.apache.spark.network.shuffle.{BlockFetchingListener,
DownloadFileManager, ShuffleClient}
+import org.apache.spark.network.shuffle.{BlockFetchingListener,
BlockStoreClient, DownloadFileManager}
import org.apache.spark.storage.{BlockId, EncryptedManagedBuffer, StorageLevel}
import org.apache.spark.util.ThreadUtils
private[spark]
-abstract class BlockTransferService extends ShuffleClient with Closeable with
Logging {
+abstract class BlockTransferService extends BlockStoreClient with Logging {
Review comment:
shall we add classdoc and mention that this class contains both server and
client?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
