xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE]
Rename ShuffleClient to BlockStoreClient which more close to its usage
URL: https://github.com/apache/spark/pull/25327#discussion_r309995027
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -459,7 +459,7 @@ private[spark] class BlockManager(
for (i <- 1 to MAX_ATTEMPTS) {
try {
// Synchronous and will throw an exception if we cannot connect.
-
shuffleClient.asInstanceOf[ExternalShuffleClient].registerWithShuffleServer(
+
shuffleClient.asInstanceOf[ExternalBlockStoreClient].registerWithShuffleServer(
Review comment:
Yep it's necessary because only ExternalBlockStoreClient has this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
