dilipbiswal commented on a change in pull request #24759:
[SPARK-27395][SQL][WIP] Improve EXPLAIN command
URL: https://github.com/apache/spark/pull/24759#discussion_r310018626
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -516,11 +543,28 @@ trait UnaryExecNode extends SparkPlan {
def child: SparkPlan
override final def children: Seq[SparkPlan] = child :: Nil
+ override def verboseString(
+ planToOperatorID : mutable.LinkedHashMap[TreeNode[_], Int],
+ codegenId: Option[Int]): String = {
+ s"""
+ |(${operatorIdStr(planToOperatorID)}) $nodeName
${wholestageCodegenIdStr(codegenId)}
+ |Input: ${child.output.mkString("[", ", ", "]")}
+ """.stripMargin
+ }
}
trait BinaryExecNode extends SparkPlan {
def left: SparkPlan
def right: SparkPlan
override final def children: Seq[SparkPlan] = Seq(left, right)
+ override def verboseString(
+ planToOperatorID: mutable.LinkedHashMap[TreeNode[_], Int],
+ codegenId: Option[Int]): String = {
+ s"""
+ |(${operatorIdStr(planToOperatorID)}) $nodeName
${wholestageCodegenIdStr(codegenId)}
+ |Left output: ${left.output.mkString("[", ", ", "]")}
+ |Right output: ${right.output.mkString("[", ", ", "]")}
Review comment:
@cloud-fan For binary exec, we again show the input which is basically
left's output and right's output. ok ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
