tgravescs commented on a change in pull request #25047: 
[WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r310183680
 
 

 ##########
 File path: docs/spark-standalone.md
 ##########
 @@ -264,6 +266,8 @@ SPARK_MASTER_OPTS supports the following system properties:
   <td>
     Path to resources file which is used to find various resources while 
worker starting up.
     The content of resources file should be formatted like the 
<code>ResourceAllocation</code> class.
+    Unlike discovery script, resources file should always assign different 
resource addresses for
+    workers/drivers(client only) whether 
<code>spark.resources.coordinate.enable</code> is off or not.
 
 Review comment:
   yeah I checked the code and we aren't differentiating resourcesFile vs 
discovery script, lets just remove that line from comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to