srowen commented on issue #25256: [SPARK-28514][ML] Remove the redundant transformImpl method in RF & GBT URL: https://github.com/apache/spark/pull/25256#issuecomment-517750077 I see. I wonder if we should be extra safe and override `transformImpl` in `ProbabilisticClassificationModel` to throw an error, and mark it final, to ensure that subclasses don't inherit it. On the other hand... is it possible a future subclass would further override `transform` and then have a use for the base class `transformImpl`? I'm OK with the current approach or further restricting inheritance of `transformImpl`. Up to your taste.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
