srowen commented on a change in pull request #25335: [SPARK-28601][CORE][SQL]
Use StandardCharsets.UTF_8 instead of "UTF-8" string representation
URL: https://github.com/apache/spark/pull/25335#discussion_r310200605
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -45,7 +45,7 @@ package object util extends Logging {
}
}
- def fileToString(file: File, encoding: String = "UTF-8"): String = {
+ def fileToString(file: File, encoding: String = UTF_8.name()): String = {
Review comment:
I wonder if we can change these private methods to accept a `Charset`? it'd
be tidier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
