srowen commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517761100 I see what you're doing, but does it make enough difference to justify the extra complexity? The only optimization that seemed possibly helpful was not referencing the boolean property each time, but pulling it into a variable. The rest doesn't seem like it would matter. Making the method private is OK, and removing the unused var.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
