dongjoon-hyun commented on a change in pull request #25315:
[SPARK-28582][PYSPARK] Fix flaky test DaemonTests.do_termination_test which
fail on Python 3.7
URL: https://github.com/apache/spark/pull/25315#discussion_r310219595
##########
File path: python/pyspark/tests/test_daemon.py
##########
@@ -47,9 +47,12 @@ def do_termination_test(self, terminator):
# daemon should accept connections
self.assertTrue(self.connect(port))
+ # wait worker process spawned from daemon exit.
+ time.sleep(1)
+
# request shutdown
terminator(daemon)
- time.sleep(1)
+ daemon.wait(5)
Review comment:
Hi, Guys.
The `timeout` argument is Python 3 only feature.
- https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait
- https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait
Since this will break Python 2.7 test in all branches. I'll revert this
commit from all the branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
