brkyvz commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-517842725 @rdblue The biggest issue is that V1 writers take logical plans and V2 writers take SparkPlans (which is much better IMO, because then you can actually see the executed query in the SQL Tab) I can see us adding `.buildForV1Writer` as part of the `WriteBuilder` API, but that means that the V2WriteExec nodes also take LogicalPlans in addition to SparkPlans. Would that be gross? I don't know. Having separate physical nodes seems reasonable to me, but it is certainly more work (mostly copy-paste though) than adding LogicalPlans to V2 nodes. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
