HyukjinKwon opened a new pull request #25343: [SPARK-28582][PYTHON] Fix flaky 
test DaemonTests.do_termination_test which fail on Python 3.7
URL: https://github.com/apache/spark/pull/25343
 
 
   ## What changes were proposed in this pull request?
   
   This PR picks up https://github.com/apache/spark/pull/25315 back after 
removing `Process.wait` usage which exists in Python 3 only. I saw the last 
test results wrongly and thought it was passed.
   
   Fix flaky test DaemonTests.do_termination_test which fail on Python 3.7. I 
add a sleep after the test connection to daemon.
   
   ## How was this patch tested?
   
   Run test
   ```
   python/run-tests --python-executables=python3.7 --testname 
"pyspark.tests.test_daemon DaemonTests"
   ```
   **Before**
   Fail on test "test_termination_sigterm". And we can see daemon process do 
not exit.
   **After**
   Test passed
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to