srowen commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r310352423
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
##########
@@ -432,4 +441,42 @@ private[kafka010] object KafkaOffsetReader {
StructField("timestamp", TimestampType),
StructField("timestampType", IntegerType)
))
+
+ lazy val schemaWithHeaders = {
+ new StructType(schemaWithoutHeaders.fields :+ StructField("headers",
headersType))
+ }
+
+ def kafkaSchema(includeHeaders: Boolean): StructType = {
+ if (includeHeaders) schemaWithHeaders else schemaWithoutHeaders
+ }
+
+ lazy val toInternalRowWithoutHeaders: Record => InternalRow =
Review comment:
Why not just `def` a function here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
