xuanyuanking commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517963453 Thanks for the review and comments. @attilapiros Yep, I tried to rename the `ExternalShuffleService` to `ExternalBlockStoreService`, compare with the present changes, it's more like an API change and influence for end users. After changing the class to `ExternalBlockStoreService`, we'll get a dilemma that should we also change the plenty of variable names, related classes and configs name. Maybe we just limit the scope to the developers, better not to the end-users. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
