HyukjinKwon commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518063722 I think we should update the guidelines to force something. If something doesn't comply to the guide line, we should fix. Otherwise, we call committer's judgement. I agree @dongjoon-hyun's in general because I fix PR descriptions and titles too when it looks not well-formed by myself. I do nitpick too time to time but maybe we should avoid to nitpick too much.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
