dongjoon-hyun commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file URL: https://github.com/apache/spark/pull/25357#discussion_r310437023
########## File path: sql/core/src/test/resources/sql-tests/results/pgSQL/with.sql.out ########## @@ -358,23 +358,20 @@ create table foo (with baz) -- !query 38 --- fail, WITH is a reserved word create table foo (with ordinality) -- !query 38 schema struct<> -- !query 38 output org.apache.spark.sql.catalyst.parser.ParseException -no viable alternative at input 'with'(line 2, pos 18) +no viable alternative at input 'with'(line 1, pos 18) == SQL == --- fail, WITH is a reserved word create table foo (with ordinality) ------------------^^^ -- !query 39 --- fail, WITH is a reserved word Review comment: Actually, these comments were helpful for me to review your `PostgreSQL` PRs to compare the result. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
