HeartSaVioR commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-518089775 First of all, whatever my intention was, apologize my bad, I was pretty bad at representing my voices in formal way if you feel this as complaint. My 2 cents was not only for this PR but across all the mood in the project. To be honest, I'd rather just follow whatever reviewers (especially someone with commit privilege) ask to fix it and don't say anything, if I just wanted to let commit be merged. Easiest way and no noise. If that's how the project works I would respect and just follow it. What I pointed out is regarding some kind of preference which sometimes make contributors back and forth, as reviewers are not sharing consistent view. If we can see the values among community, we could reach a consensus in official discussion (either small or require votes) and require it. I'm afraid it can be educated, and it should be educated once someone feels it as preference. Honestly, the only way to correct it would be correcting time to time. Contributors can't read reviewers' mind in prior.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
