cloud-fan commented on a change in pull request #25107: [SPARK-28344][SQL]
detect ambiguous self-join and fail the query
URL: https://github.com/apache/spark/pull/25107#discussion_r310443661
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.scala
##########
@@ -78,7 +79,8 @@ class HiveSessionStateBuilder(session: SparkSession,
parentState: Option[Session
customResolutionRules
override val postHocResolutionRules: Seq[Rule[LogicalPlan]] =
- new DetermineTableStats(session) +:
+ new DetectAmbiguousSelfJoin(conf) +:
Review comment:
I need to know the details of each rule so that I can write a test to make
sure these rules are included. Maybe do it in a followup instead of blocking
this PR? BTW the new tests added in this PR do guarantee the
`DetectAmbiguousSelfJoin` rule is there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
