dongjoon-hyun commented on a change in pull request #25358:
[SPARK-28622][SQL][PYTHON] Rename PullOutPythonUDFInJoinCondition to
ExtractPythonUDFFromJoinCondition and move to 'Extract Python UDFs'
URL: https://github.com/apache/spark/pull/25358#discussion_r310680528
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -183,10 +183,7 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
Batch("LocalRelation", fixedPoint,
ConvertToLocalRelation,
PropagateEmptyRelation) :+
- Batch("Extract PythonUDF From JoinCondition", Once,
- PullOutPythonUDFInJoinCondition) :+
- // The following batch should be executed after batch "Join Reorder"
"LocalRelation" and
- // "Extract PythonUDF From JoinCondition".
+ // The following batch should be executed after batch "Join Reorder"
"LocalRelation".
Review comment:
From the previous comment, `and` seems to be still missing. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
