mccheah commented on a change in pull request #25361: [SPARK-28625][Core]
Indeterminate shuffle support in Shuffle Writer API
URL: https://github.com/apache/spark/pull/25361#discussion_r310722152
##########
File path:
core/src/main/java/org/apache/spark/shuffle/api/ShuffleExecutorComponents.java
##########
@@ -39,16 +39,20 @@
/**
* Called once per map task to create a writer that will be responsible for
persisting all the
* partitioned bytes written by that map task.
- * @param shuffleId Unique identifier for the shuffle the map task is a
part of
+ * @param shuffleId Unique identifier for the shuffle the map task is a part
of
+ * @param shuffleGenerationId The shuffle generation ID of the stage that
this task belongs to,
Review comment:
Specifically taking a look at the linked PR for indeterminate retries - I'd
expect that on a rolled back map stage, the implementation of this plugin will
be given a different `mapTaskAttemptId` anyways since that's going to be
updated on the resubmit. So, we'll end up opening a new writer regardless, but,
we could have gotten the same behavior just by using the `mapTaskAttemptId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
