Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/4096#issuecomment-70487065
@mengxr The other PR that you refer to implements sorting, this however
implements O(size) check for sparse vectors where size is typically really
small (It does not support negative indices).
Even `scipy.sparse.coo_matrix` does a check here
(https://github.com/scipy/scipy/blob/master/scipy/sparse/coo.py#L263) for
negative row indices.
Please tell me if you still feel that this Pull Request is not that useful.
I shall close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
