skonto commented on a change in pull request #25229: [SPARK-27900][K8s] Add jvm
oom flag
URL: https://github.com/apache/spark/pull/25229#discussion_r310948602
##########
File path:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh
##########
@@ -60,14 +60,44 @@ if ! [ -z ${HADOOP_CONF_DIR+x} ]; then
SPARK_CLASSPATH="$HADOOP_CONF_DIR:$SPARK_CLASSPATH";
fi
+IGNORE_DEFAULT_DRIVER_JVM_OPTIONS=${IGNORE_DEFAULT_DRIVER_JVM_OPTIONS:-false}
Review comment:
@dongjoon-hyun Ok so that is what I also concluded :) I can do that, it
looks fine to me, the only issue is that this way we open the door to adding
arbitrary options there. Initially that was what I didnt want to support, thus
I used that the flag to make defaults unchangeable (defaults usually have fixed
values).
The other thing is the code here adds the flag by default with the approach
you mention you will not get it if you specify `extraJavaoptions` yourself.
But we could be flexible here for simplicity reasons, what I have is a bit
too much, so I will change to what you suggest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
